Skip to content

Fix merge override attrs reference issue #11506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nocdoggo wants to merge 5 commits into
base: main
Choose a base branch
from
+3 −1
Open

Fix merge override attrs reference issue #11506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10a871a
SWE-bench
Sep 10, 2025
fe4dd92
wp3b-baseline
Aug 11, 2026
616c998
Fix merge override attrs reference issue\n\nWhen using combine_attrs=…
openhands-agent Aug 11, 2026
0c6c0b7
Add whats-new entry for attrs copy fix
openhands-agent Aug 11, 2026
7b37cbf
Add whats-new entry for attrs copy fix
openhands-agent Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4915,3 +4915,5 @@ v0.1 (2 May 2014)
-----------------

Initial release.
- Fixed bug where merge(combine_attrs='override') was not copying attrs but instead referencing attrs from the first object. (:issue:)
- Fixed bug where ``merge(combine_attrs='override')`` was not copying attrs but instead referencing attrs from the first object. (:issue:`4629`)
2 changes: 1 addition & 1 deletion xarray/core/merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ def merge_attrs(variable_attrs, combine_attrs):
if combine_attrs == "drop":
return {}
elif combine_attrs == "override":
return variable_attrs[0]
return dict(variable_attrs[0])
Comment on lines 503 to +504
elif combine_attrs == "no_conflicts":
result = dict(variable_attrs[0])
for attrs in variable_attrs[1:]:
Expand Down