Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated See also section in the docstrings broke numpydoc #8596

Open
5 tasks
maximlt opened this issue Jan 8, 2024 · 0 comments
Open
5 tasks

Updated See also section in the docstrings broke numpydoc #8596

maximlt opened this issue Jan 8, 2024 · 0 comments

Comments

@maximlt
Copy link
Contributor

maximlt commented Jan 8, 2024

What happened?

Hi, I would like to report that #8311 broke the documentation build of Datashader. Datashader's documentation uses Sphinx and numpydoc to process its docstrings. It turns out (I had no idea) that numpydoc processes more doctrings than I'd have expected, including xarray's ones. The changes in the PR made numpydoc unhappy. To reproduce run:

python3 -m venv .venv                                                                                         
source .venv/bin/activate
pip install numpydoc
python -m numpydoc.hooks.validate_docstrings xarray/core/dataarray.py

You'll get this error:

ValueError: Error parsing See Also entry ':doc:`xarray-tutorial:intermediate/indexing/indexing`'

I'm pretty sure this is not an xarray issue but felt that opening an issue here might be useful for others encountering this issue. Really, feel free to close it.

What did you expect to happen?

No response

Minimal Complete Verifiable Example

No response

MVCE confirmation

  • Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
  • Complete example — the example is self-contained, including all data and the text of any traceback.
  • Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
  • New issue — a search of GitHub Issues suggests this is not a duplicate.
  • Recent environment — the issue occurs with the latest version of xarray and its dependencies.

Relevant log output

No response

Anything else we need to know?

No response

Environment

@maximlt maximlt added bug needs triage Issue that has not been reviewed by xarray team member labels Jan 8, 2024
@TomNicholas TomNicholas added topic-documentation and removed needs triage Issue that has not been reviewed by xarray team member labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants