Docs: ignore numpydoc validation checks #1310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc build was broken with:
It turns out Datashader doesn't use the
sphinx.ext.napoleon
extension to process its docstrings but numpydoc, which does more validation (than I would have expected at least) and wasn't happy with some recent changes made in xarray (see pydata/xarray#8596). I tried:sphinx.ext.napoleon
but the API page didn't look the same and I didn't want to find what changed exactly and if it was better or worse.So I ended up figuring out how to disable all the validations numpydoc performs. We probably need to revert that some day.
EDIT: Meh I must have done something wrong in my testing, this doesn't work yet.
EDIT2:
Datashader uses
sphinx.ext.autodoc
(e.g. theautomodule
directive) for its API reference and automatically includes a module that contains theImage
class.Image
inherits fromxr.DataArray
. Datashader uses numpydoc to parse the docstrings. It turns out xarray affected numpydoc in some way (see pydata/xarray#8596). I found a (bad) hacky way to work around that.