Skip to content

Commit

Permalink
Skip flaky test_open_mfdataset_manyfiles test (#8989)
Browse files Browse the repository at this point in the history
* Skip flaky `test_open_mfdataset_manyfiles` test

Don't just xfail, and not only on windows, since it can crash the worked

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
max-sixty and pre-commit-ci[bot] authored Apr 30, 2024
1 parent 0d6662e commit 7f99f9e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions xarray/tests/test_backends.py
Original file line number Diff line number Diff line change
Expand Up @@ -3813,11 +3813,11 @@ def skip_if_not_engine(engine):
pytest.importorskip(engine)


# Flaky test. Very open to contributions on fixing this
@requires_dask
@pytest.mark.filterwarnings("ignore:use make_scale(name) instead")
@pytest.mark.xfail(reason="Flaky test. Very open to contributions on fixing this")
@pytest.mark.skipif(ON_WINDOWS, reason="Skipping on Windows")
@pytest.mark.skip(
reason="Flaky test which can cause the worker to crash (so don't xfail). Very open to contributions fixing this"
)
def test_open_mfdataset_manyfiles(
readengine, nfiles, parallel, chunks, file_cache_maxsize
):
Expand Down

0 comments on commit 7f99f9e

Please sign in to comment.