Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add __binsparse__ protocol. #764

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
+318 −85
Draft

feat: Add __binsparse__ protocol. #764

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d952891
Add `__binsparse_descriptor__` and `__binsparse_dlpack__`.
hameerabbasi Sep 2, 2024
e593a7b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 3, 2024
0a5fdda
Update with suggestions from @pearu.
hameerabbasi Sep 24, 2024
00aaebd
Recognize `"COOR"` format and use simpler representation for it.
hameerabbasi Sep 26, 2024
edaa60e
Fix bug where `dtype.itemsize` was assumed to be in bits rather than …
hameerabbasi Sep 26, 2024
7b9e779
Fix bug where `format` property was not correct for all formats.
hameerabbasi Sep 26, 2024
51823d4
Fix `notebooks` feature and add it to development environments.
hameerabbasi Sep 26, 2024
9624514
Get `COO` round-trip working.
hameerabbasi Sep 26, 2024
a333112
Get `CSR` round-trip working.
hameerabbasi Sep 26, 2024
c0743b9
Fix up test.
hameerabbasi Sep 26, 2024
199d878
Remove debugging `print` statement.
hameerabbasi Sep 27, 2024
0dfa265
`nnz` may not fit in `uint8`.
hameerabbasi Sep 27, 2024
c314d08
Update to latest agreed-upon `binsparse` protocol version.
hameerabbasi Feb 19, 2025
148d1aa
Test with latest version of `codecov-action`.
hameerabbasi Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove debugging print statement.
@hameerabbasi
hameerabbasi committed Feb 19, 2025

Verified

This commit was signed with the committer’s verified signature.
hameerabbasi Hameer Abbasi
SSH Key Fingerprint: X6YoaKttcULHBRzJSVjFjva1dltqtg6NtVF7Zbe0ifg
Verified
Learn about vigilant mode
commit 199d87804887bf4c2ed0d8b12a85e564e8183025
1 change: 0 additions & 1 deletion sparse/numba_backend/_io.py
View file
Original file line number Diff line number Diff line change
@@ -279,7 +279,6 @@ def from_binsparse(arr, /, *, device=None, copy: bool | None = None) -> SparseAr

return sparse_type((val_arr, ptr_arr, crd_arr), shape=shape)
case _:
print(desc)
raise RuntimeError(format_err_str)