Trim some rendundant CSS from _header.scss #1847
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabalafou
commented
Jun 3, 2024
| @@ -82,8 +82,6 @@ | |||
|
|
|||
| // Contains the navigation links within the navbar | |||
| .navbar-nav { | |||
| display: flex; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh but the _navbar-nav.scss file changes the ul to display: block... Hmm, this might be more complicated than I realize. I'm going to put this PR into draft mode.
| @@ -106,10 +104,6 @@ | |||
| @include header-link; | |||
| } | |||
|
|
|||
| li a.nav-link.dropdown-item { | |||
| @include link-style-text; | |||
There was a problem hiding this comment.
This line just applies the same mixin that _navbar-nav.scss appiles. The only difference is that the selector here, .bd-header .navbar-nav li a.nav-link.dropdown-item, is more specific than the other selector, .navbar-nav li a, but the specificity isn't needed to override anything, as far as I can tell.
gabalafou
added
tag: CSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments