Allow durations without leading 0s in the hour #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pydantic/pydantic#8248
Supports the following formats:
Note that this is technically a breaking change due to the change in error type when there are characters left over after parsing a duration, from
InvalidCharTzSign
toExtraCharacters
. I think this makes more sense as there is no such thing as a valid timezone for a duration.I started down the road of trying to unify the time parsing between durations and times using
PureTime
, but it became a bit of a mess, requiring breaking changes toPureTime
(e.g.PureTime
stores hours as au8
currently, but duration parsing needs at leastu32
).