Add GraphRun object to make use of next more ergonomic
#833
+66
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmontagu
changed the title
next more ergonomic
Merged
dmontagu
force-pushed
the
dmontagu/graph-run-object
branch
from
6ce755e to
571d805
Compare
dmontagu
force-pushed
the
dmontagu/stream-tool-calls
branch
from
1443b49 to
c4e9180
Compare
dmontagu
force-pushed
the
dmontagu/graph-run-object
branch
from
571d805 to
04fc74c
Compare
dmontagu
commented
Feb 1, 2025
| @@ -184,19 +184,12 @@ async def main(): | |||
|
|
|||
| next_node = start_node | |||
| while True: | |||
| next_node = await self.next(next_node, history, state=state, deps=deps, infer_name=False) | |||
| next_node = await graph_run.next(next_node) | |||
There was a problem hiding this comment.
The simplicity of this loop is the primary reason I want to have a graph_run object — it just feels like there's so much less cruft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of trying to reduce the amount of stuff happening in
Graph.runthat wasn't just innext.I made some related improvements I discovered while working on this in #834, but I think there are still some advantages to a
GraphRunobject.The main two benefits of this are:
state,deps,history, orinfer_nameafter starting the "run". I understand that for the sake of interrupting etc. that that you need to be able to set these things, but it feels reasonable to me to interrupt theGraphRunas a whole — since we can start/stop runs from any node I don't see a problem with this. (I didn't expose a way to set the history of a run, but it would be trivial to add that.) And needing to keep a reference todepsetc., or even just pass the relevant arguments just feels kind of non-ergonomic when you just want actual streaming (not interrupts).nextto manage history themselves then the value of this is reduced, but we would still need to basically duplicate the history handling inAgent.nextsinceGraph.nextwon't do it for us.I expect we'll close this PR without merging, but I wanted to at least share the implementation as a proof of concept.