Skip to content

Conversation

Lonercode
Copy link

@Lonercode Lonercode commented Sep 10, 2025

This PR fixes an issue with the ConsoleOptions configuration where the output argument was missing from the config, causing errors when trying to redirect logs. The change adds the output argument. A proposed fix for issue 1390

Test coverage dropped on console.py due to a new if-else branch I added. I plan to review the tests to understand the missing coverage.

Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
logfire/_internal/exporters/console.py 14.28% 5 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@alexmojaki
Copy link
Contributor

This is the right start, but it doesn't actually do anything yet.

@Lonercode
Copy link
Author

Thanks for the feedback :) I guess you mean that instead of just adding the output argument, I should make it so that it redirects the logs to sys.stdout or sys.stderr .

@alexmojaki
Copy link
Contributor

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants