This repository was archived by the owner on Aug 11, 2021. It is now read-only.
allow redirecting to the first page when an invalid page is requested #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2020 09:01
The way settings are imported in the pagination_tags module makes it difficult to override them in tests because they are evaluated on import. I propose define defaults in a defaults.py file and actually evaluate the setting via a getter only when they are used.
When the number of items in a collection varies, it happens that urls, already shared on the web, point to a page that is now invalid. Up to now dj-pagination only allowed to either render nothing or raise a 404 page. Another good practice to prevent broken links is to redirect to the first page with a 301 http code.
|
Hey @pydanny, are you still maintaining this project? We have a few improvements to make so we propose to take over its maintenance at https://github.com/openfun? Otherwise we need to fork it or vendor it in our project. What do you think is the best solution? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When the number of items in a collection varies, it happens that urls, already shared on the web, point to a page that is now invalid.
Up to now,
dj-paginationonly allowed to either render nothing or raise a 404 page.Another good practice to prevent broken links is to redirect to the first page with a 301 http code.
Proposal
PAGINATION_INVALID_PAGE_TRIGGERS_301. When set to True, invalid pages raise an PaginationRedirect exception when an invalid page is requestedFixes #24