Skip to content

Conversation

@xchwan
Copy link
Collaborator

@xchwan xchwan commented Aug 25, 2025

Types of changes

  • New feature

Description

gemini分類kktix的職業和公司, 會產生三個表格

kktix_ticket_organization =>gemini產業分類
kktix_ticket_job_title =>gemini職業分類
kktix_ticket_user_profile=>kktix使用者所有資料

@xchwan xchwan requested a review from Lee-W August 25, 2025 16:10
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor suggestion but non-blockers

@Lee-W
Copy link
Member

Lee-W commented Aug 28, 2025

@xchwan, feel free to resolve those two if you don't think they actually improve the quality. I feel it's more of a taste thing.
What is the typical review and deployment flow? do I need to merge and deploy it or will you do taht

@xchwan
Copy link
Collaborator Author

xchwan commented Aug 28, 2025

@xchwan, feel free to resolve those two if you don't think they actually improve the quality. I feel it's more of a taste thing. What is the typical review and deployment flow? do I need to merge and deploy it or will you do taht

Modify done. Actually, there is no "typical" review and deployment flow. Everyone can merge and deploy. feel free to merge and deploy if you think this PR is okay.

@Lee-W
Copy link
Member

Lee-W commented Aug 30, 2025

sounds good. let me merge it and deploy it

@Lee-W Lee-W force-pushed the app/user_profile_bigquery branch from 83c35bb to 43b6344 Compare August 30, 2025 01:56
@Lee-W Lee-W merged commit abddb78 into master Aug 30, 2025
2 checks passed
@Lee-W Lee-W deleted the app/user_profile_bigquery branch August 30, 2025 02:12
@Lee-W
Copy link
Member

Lee-W commented Aug 30, 2025

just deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants