Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release.yml #1926

Merged
merged 2 commits into from
Nov 22, 2024
Merged

fix: release.yml #1926

merged 2 commits into from
Nov 22, 2024

Conversation

studioj
Copy link
Collaborator

@studioj studioj commented Nov 22, 2024

@studioj studioj requested a review from adehad November 22, 2024 21:13
@github-actions github-actions bot added the bug label Nov 22, 2024
@studioj
Copy link
Collaborator Author

studioj commented Nov 22, 2024

@wulmer @mojicae :-) all eyes help in a review

wulmer
wulmer approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@wulmer wulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, will likely fix the error, however I don't see the connection to the removal of docker-compose, but installing libkrb5-dev seems ok.

@adehad adehad merged commit ab9a69b into main Nov 22, 2024
16 checks passed
@adehad adehad deleted the fix-release-dependencies branch November 22, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adehad adehad adehad approved these changes

@wulmer wulmer wulmer approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@studioj @wulmer @adehad