Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pagination in createmeta methods #1729

Merged
merged 6 commits into from
Dec 23, 2023
Merged

Conversation

paminov
Copy link
Contributor

@paminov paminov commented Sep 5, 2023

createmeta_fieldtypes and createmeta_issuetypes currently do not pass any pagination parameters to _get_json. Which makes it impossible to get any values beyond the first page. This fix adds startAt and maxResults to both methods.

paminov and others added 2 commits September 5, 2023 16:57
`createmeta_fieldtypes` and `createmeta_issuetypes` currently do not pass any pagination parameters to `_get_json`. Which makes it impossible to get any values beyond the first page. This fix adds `startAt` and `maxResults` to both methods.
@paminov
Copy link
Contributor Author

paminov commented Sep 6, 2023

fixes #1699

jira/client.py Show resolved Hide resolved
jira/client.py Show resolved Hide resolved
add docstrings for `startAt` and `maxResults` kwargs.
@paminov paminov temporarily deployed to ack October 4, 2023 21:01 — with GitHub Actions Inactive
@paminov
Copy link
Contributor Author

paminov commented Oct 8, 2023

@nickmitricka Do you happen to know why one of the checks is stuck Expected — Waiting for status to be reported? Did a job name change? Can the check be restarted?
Thank you!
Edit: looks like a bunch of PRs are stuck in the same state.

@nickmitricka
Copy link

nickmitricka commented Oct 8, 2023

@nickmitricka Do you happen to know why one of the checks is stuck Expected — Waiting for status to be reported? Did a job name change? Can the check be restarted? Thank you! Edit: looks like a bunch of PRs are stuck in the same state.

Unfortunately, I don't. I'm not able to even approve the merge it looks like. I just know I need this functionaility and was trying to help get it done :-)

EDIT: Looks like its a workflow issue and not finding pip? https://github.com/pycontribs/jira/actions/runs/6411432440/workflow

@nickmitricka
Copy link

@paminov - Also, I was just reading through the contribution documentation, it looks like it might also require there to be test cases written to ensure that this bug is fixed:
https://jira.readthedocs.io/contributing.html#pull-requests

@SharryXu
Copy link

We really need this feature and hope it can be available in the latest release.

@SharryXu
Copy link

Hi @ssbarnea and @adehad ,
Thanks for your hard work 👍
Do we have plans on shipping this feature in the next release?

Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent quality PR, thank you for your contribution.

@SharryXu @paminov the aim will to have this in a release at the start of the new year (avoiding a release in the middle of the holidays.

@adehad adehad merged commit 686de78 into pycontribs:main Dec 23, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants