-
-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support pagination in createmeta methods #1729
Conversation
`createmeta_fieldtypes` and `createmeta_issuetypes` currently do not pass any pagination parameters to `_get_json`. Which makes it impossible to get any values beyond the first page. This fix adds `startAt` and `maxResults` to both methods.
for more information, see https://pre-commit.ci
fixes #1699 |
add docstrings for `startAt` and `maxResults` kwargs.
@nickmitricka Do you happen to know why one of the checks is stuck |
Unfortunately, I don't. I'm not able to even approve the merge it looks like. I just know I need this functionaility and was trying to help get it done :-) EDIT: Looks like its a workflow issue and not finding |
@paminov - Also, I was just reading through the contribution documentation, it looks like it might also require there to be test cases written to ensure that this bug is fixed: |
We really need this feature and hope it can be available in the latest release. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createmeta_fieldtypes
andcreatemeta_issuetypes
currently do not pass any pagination parameters to_get_json
. Which makes it impossible to get any values beyond the first page. This fix addsstartAt
andmaxResults
to both methods.