Use the proxy scheme in case it is different

pycontribs · Nov 22, 2024 · 7ee7bfc · 7ee7bfc
1 parent 427e6e3
commit 7ee7bfc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/jira/resources.py b/jira/resources.py
@@ -309,7 +309,7 @@ def _validate_self_self_url(self):
         if self_parsed.netloc != server_parsed.netloc:
             self.self = urlunparse(
                 ParseResult(
-                    scheme=self_parsed.scheme,
+                    scheme=server_parsed.scheme,
                     netloc=server_parsed.netloc,
                     path=self_parsed.path,
                     params=self_parsed.params,

diff --git a/tests/resources/test_issue.py b/tests/resources/test_issue.py
@@ -347,7 +347,7 @@ def test_update_label_with_proxy(self):
 
         labelarray = ["testLabel"]
         fields = {"labels": labelarray}
-        issue.self = f"http://foo.bar/jira/rest/api/2/issue/{issue.id}"
+        issue.self = f"https://foo.bar/jira/rest/api/2/issue/{issue.id}"
         issue.update(fields=fields)
         self.assertEqual(issue.fields.labels, ["testLabel"])
 
@@ -395,7 +395,7 @@ def test_delete_with_proxy(self):
             issuetype=self.test_manager.CI_JIRA_ISSUE,
         )
         key = issue.key
-        issue.self = f"http://foo.bar/jira/rest/api/2/issue/{issue.id}"
+        issue.self = f"https://foo.bar/jira/rest/api/2/issue/{issue.id}"
         issue.delete()
         self.assertRaises(JIRAError, self.jira.issue, key)