Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admissions): add admission type for the admissions extension #11883

Merged
merged 3 commits into from
Nov 3, 2024
Merged

feat(admissions): add admission type for the admissions extension #11883

merged 3 commits into from
Nov 3, 2024

Conversation

hoefling
Copy link
Contributor

@hoefling hoefling commented Nov 3, 2024

This is the third PR for #11875. The relevant part of the ASN.1 syntax, as specified in Common PKI v2.0, Table 29b:

Admissions ::= SEQUENCE {
  admissionAuthority [0] EXPLICIT GeneralName OPTIONAL,
  namingAuthority [1] EXPLICIT NamingAuthority OPTIONAL,
  professionInfos SEQUENCE OF ProfessionInfo
}

alex
alex reviewed Nov 3, 2024
View reviewed changes
src/rust/cryptography-x509/src/extensions.rs
Comment on lines +321 to +325
/*
pub profession_infos: common::Asn1ReadableOrWritable<
asn1::SequenceOf<'a, ProfessionInfo<'a>>,
asn1::SequenceOfWriter<'a, ProfessionInfo<'a>, Vec<ProfessionInfo<'a>>>,
>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this needs to be commented out because the traits are not yet available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex yes exactly, the SequenceOfWriter expects the Asn1Readable/Writable traits, orherwise the code will not compile.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine for now.

@alex alex merged commit 4d86913 into pyca:main Nov 3, 2024
60 checks passed
@hoefling hoefling deleted the feature/extension/admissions/types/admission branch November 4, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoefling @alex