-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model parallelization #645
base: develop
Are you sure you want to change the base?
Model parallelization #645
Conversation
There are some integration tests about half-cell models that are failing, all with the following message:
I'm pretty sure my code changes could not have caused this. |
But I found an issue with pickling models that have been used in predictions, so I will have to issue another commit anyways. |
Found it: whenever a |
…ix to problem classes
There are some tests still failing, but I don't think they relate to changes I did. |
Description
Makes pybop.Dataset instances and instances of pybop.models.base_echem children both copyable and pickleable, enabling all the usual object-oriented and parallelization patterns.
Issue reference
Fixes #642
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks: