-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIM added for PyBOP likelihood functions #632
FIM added for PyBOP likelihood functions #632
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #632 +/- ##
===========================================
+ Coverage 99.22% 99.25% +0.02%
===========================================
Files 62 63 +1
Lines 4536 4686 +150
===========================================
+ Hits 4501 4651 +150
Misses 35 35 ☔ View full report in Codecov by Sentry. |
fb280b9
to
7e7f145
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great @Dibyendu-IITKGP — a few comments to think about!
examples/notebooks/battery_parameterisation/monte_carlo_ecm_identification.ipynb
Outdated
Show resolved
Hide resolved
Co-authored-by: Brady Planden <[email protected]>
Co-authored-by: Brady Planden <[email protected]>
…rix-to-likelihood-cost
61eb5fd
to
ccaa8c7
Compare
…x-to-likelihood-cost' into 630-add-fisher-information-matrix-to-likelihood-cost # Conflicts: # tests/unit/test_likelihoods.py
…rix-to-likelihood-cost # Conflicts: # pybop/optimisers/base_optimiser.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @Dibyendu-IITKGP!
Description
Compute the observed Fisher Information Matrix (FIM) for the given inputs. The FIM is computed using the square of the gradient, divided by the number of data points.
Issue reference
Fixes #630
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.