Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splits EIS methods from BaseModel w/ refactoring #616

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor: splits supporting EIS methods from BaseModel, combines simu…
…late() and simulateEIS(), general BaseModel refactoring
  • Loading branch information
BradyPlanden committed Jan 9, 2025
commit 4506aa6a5b58ef404c74baa26c098a33a51d836a
5 changes: 3 additions & 2 deletions examples/scripts/battery_parameterisation/eis_fitting.py
Original file line number Diff line number Diff line change
@@ -16,13 +16,14 @@
)

# Create synthetic data for parameter inference
sim = model.simulateEIS(
sim = model.simulate(
inputs={
"Negative electrode active material volume fraction": 0.531,
"Positive electrode active material volume fraction": 0.732,
},
f_eval=f_eval,
eval=f_eval,
initial_state=initial_state,
eis=True,
)

# Fitting parameters
2 changes: 1 addition & 1 deletion examples/scripts/comparison_examples/grouped_SPMe.py
Original file line number Diff line number Diff line change
@@ -99,7 +99,7 @@
impedances = 1j * np.zeros((Nfreq, NSOC))
for ii, SOC in enumerate(SOCs):
model.set_initial_state({"Initial SoC": SOC})
simulation = model.simulateEIS(inputs=None, f_eval=frequencies)
simulation = model.simulate(inputs=None, eval=frequencies, eis=True)
impedances[:, ii] = simulation["Impedance"]

if i == 0:
Original file line number Diff line number Diff line change
@@ -64,7 +64,7 @@ def inputs():

start_time = time.time()
for _i in range(n):
out = problem.model.simulate(inputs=inputs(), t_eval=t_eval)
out = problem.model.simulate(inputs=inputs(), eval=t_eval)
print(f"({solver.name}) Time model.simulate: {time.time() - start_time:.4f}")

start_time = time.time()
Loading
Loading