-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
importing cycler data to PyBOP notebook example added #522
base: develop
Are you sure you want to change the base?
importing cycler data to PyBOP notebook example added #522
Conversation
@BradyPlanden I think with this example, we can remove previously added |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #522 +/- ##
===========================================
+ Coverage 99.08% 99.15% +0.07%
===========================================
Files 52 56 +4
Lines 3605 3918 +313
===========================================
+ Hits 3572 3885 +313
Misses 33 33 ☔ View full report in Codecov by Sentry. |
0b2e1a4
to
e58c374
Compare
5c6c8a2
to
53e51d9
Compare
4e3db75
to
c45fff2
Compare
92f0c0c
to
69de744
Compare
Description
A example notebook file is added to demonstrate how to import battery cycler data directly to PyBOP without any pre-processing. Battery-Data-Toolkit is used for this purpose. However, a similar kind of approach can be followed for any battery cycler data converter (example: cellpy etc.). It is also shown how to use part of the cycler data to fit HPPC pulses and estimate equivalent circuit parameters.
Issue reference
Fixes #504
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.