Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart_holder] Bake smart_holder functionality into class_ and type_caster_base #5257

Merged
merged 19 commits into from
Jul 31, 2024

Commits on Jul 21, 2024

  1. Put bakein branch @ 18b72c0 on top of smart_holder branch:

    Commands used:
    
    ```
    git checkout bakein
    git diff smart_holder > ~/zd
    git checkout smart_holder
    git checkout -b bakein_sh
    patch -p 1 < ~/zd
    git checkout smart_holder \
    MANIFEST.in \
    README.rst \
    README_smart_holder.rst \
    docs/advanced/smart_ptrs.rst \
    ubench/holder_comparison.cpp \
    ubench/holder_comparison.py \
    ubench/holder_comparison_extract_sheet_data.py \
    ubench/number_bucket.h \
    ubench/python/number_bucket.clif
    git add -A
    ```
    Ralf W. Grosse-Kunstleve committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    82c9ce7 View commit details
    Browse the repository at this point in the history
  2. Add back README_smart_holder.rst in tests/extra_python_package/test_f…

    …iles.py
    Ralf W. Grosse-Kunstleve committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    fbd1295 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'smart_holder' into bakein_sh

    Ralf W. Grosse-Kunstleve committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    58f9e18 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Restore smart_holder_poc.h as-is on smart_holder branch (i.e. undo `P…

    …YBIND11_SMART_HOLDER_PADDING`, which was meant for stress-testing only).
    Ralf W. Grosse-Kunstleve committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c02d2cd View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Insert std::move() as suggested by @laramiel

    Ralf W. Grosse-Kunstleve committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    99b6572 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    16cf7ad View commit details
    Browse the repository at this point in the history
  3. Call property_cpp_function_classic member functions, rather than in…

    …lining the implementations.
    Ralf W. Grosse-Kunstleve committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    0bcfbd4 View commit details
    Browse the repository at this point in the history
  4. Use PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT in holder_com…

    …parison.cpp (holder_comparison.py is NOT changed accordingly in this commit, i.e. can still only be run if the smart_holder functionality is available).
    Ralf W. Grosse-Kunstleve committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    2644d6e View commit details
    Browse the repository at this point in the history
  5. Systematically rename loaded_as to load_as (shared_ptr, `unique…

    …_ptr`) as suggested by @laramiel
    Ralf W. Grosse-Kunstleve committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    336860d View commit details
    Browse the repository at this point in the history
  6. Make change as suggested by @laramiel. This makes it much more obviou…

    …s that the latest implementation of `smart_holder_from_unique_ptr()` accepts all existing `return_value_policy` enum values except `copy`.
    Ralf W. Grosse-Kunstleve committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    cb6a85f View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Resolve BAKEIN_WIP: Rewrite comment. for property_cpp_function_*

    …specializations.
    Ralf W. Grosse-Kunstleve committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    0316f74 View commit details
    Browse the repository at this point in the history
  2. Resolve `BAKEIN_WIP: Add comment to explain: This is meant for stress…

    …-testing only.`
    Ralf W. Grosse-Kunstleve committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    053467f View commit details
    Browse the repository at this point in the history
  3. Resolve all remaining BAKEIN_WIP (in pybind11/cast.h).

    Leave only two pairs of SMART_HOLDER_BAKEIN_FOLLOW_ON comments: refactoring of copyable_holder_caster, move_only_holder_caster. This is best left until after the smart_holder branch is merged into the master branch.
    Ralf W. Grosse-Kunstleve committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    523eafa View commit details
    Browse the repository at this point in the history
  4. Remove obsolete using holder_type = smart_holder; in load_helper

    Ralf W. Grosse-Kunstleve committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    7c0aed7 View commit details
    Browse the repository at this point in the history
  5. Add SMART_HOLDER_BAKEIN_FOLLOW_ON comment for `internals::default_hol…

    …der`
    Ralf W. Grosse-Kunstleve committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    0ca3ca7 View commit details
    Browse the repository at this point in the history
  6. README_smart_holder.rst update (line count reduced from 356 to 123).

    Ralf W. Grosse-Kunstleve committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    4a7f895 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Merge branch 'sh_merge_master' into bakein_sh_merge_ahead

    Ralf W. Grosse-Kunstleve committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    67ac541 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'sh_merge_master' into bakein_sh

    Ralf W. Grosse-Kunstleve committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    8ffe837 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Merge branch 'smart_holder' into bakein_sh

    Ralf W. Grosse-Kunstleve committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    2e9769a View commit details
    Browse the repository at this point in the history