Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart_holder] git merge master #5252

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Commits on Jul 18, 2024

  1. docs: extend PYBIND11_MODULE documentation, mention `mod_gil_not_us…

    …ed` (pybind#5250)
    
    This follows up on PR 5148, which introduced support for free-threaded CPython.
    rgommers authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    dbf848a View commit details
    Browse the repository at this point in the history
  2. tests: run on pyodide (pybind#4745)

    * tests: run on pyodide
    
    Signed-off-by: Henry Schreiner <[email protected]>
    
    * ci: use cibuildwheel for pyodide test
    
    Signed-off-by: Henry Schreiner <[email protected]>
    
    * tests: revert changes to test_embed
    
    Signed-off-by: Henry Schreiner <[email protected]>
    
    ---------
    
    Signed-off-by: Henry Schreiner <[email protected]>
    henryiii authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a582ca8 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Small cleanup/refactoring in support of PR pybind#5213 (pybind#5251)

    * Factor out detail/value_and_holder.h (from detail/type_caster_base.h)
    
    This is in support of PR pybind#5213:
    
    * trampoline_self_life_support.h depends on value_and_holder.h
    
    * type_caster_base.h depends on trampoline_self_life_support.h
    
    * Fix a minor and inconsequential inconsistency in `copyable_holder_caster`: the correct `load_value()` return type is `void` (as defined in `type_caster_generic`)
    
    For easy future reference, this is the long-standing inconsistency:
    
    * https://github.com/pybind/pybind11/blob/dbf848aff7c37ef8798bc9459a86193e28b1032f/include/pybind11/detail/type_caster_base.h#L634
    
    * https://github.com/pybind/pybind11/blob/dbf848aff7c37ef8798bc9459a86193e28b1032f/include/pybind11/cast.h#L797
    
    Noticed in passing while working on PR pybind#5213.
    
    * Add `DANGER ZONE` comment in detail/init.h, similar to a comment added on the smart_holder branch (all the way back in 2021).
    Ralf W. Grosse-Kunstleve authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6d4805c View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into sh_merge_master

    Ralf W. Grosse-Kunstleve committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    08e234d View commit details
    Browse the repository at this point in the history
  3. Replace #include "detail/type_caster_base.h" with `#include "detail…

    …/value_and_holder.h"` in trampoline_self_life_support.h. This was made possible by PR pybind#5251.
    Ralf W. Grosse-Kunstleve committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e933e21 View commit details
    Browse the repository at this point in the history