Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanup/refactoring in support of PR #5213 #5251

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Small cleanup/refactoring in support of PR #5213 #5251

merged 3 commits into from
Jul 19, 2024

Commits on Jul 18, 2024

  1. Factor out detail/value_and_holder.h (from detail/type_caster_base.h) 

    This is in support of PR pybind#5213:

* trampoline_self_life_support.h depends on value_and_holder.h

* type_caster_base.h depends on trampoline_self_life_support.h
    Ralf W. Grosse-Kunstleve committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5e30064 View commit details
    Browse the repository at this point in the history

  2. Fix a minor and inconsequential inconsistency in `copyable_holder_cas… 

    …ter`: the correct `load_value()` return type is `void` (as defined in `type_caster_generic`)

For easy future reference, this is the long-standing inconsistency:

* https://github.com/pybind/pybind11/blob/dbf848aff7c37ef8798bc9459a86193e28b1032f/include/pybind11/detail/type_caster_base.h#L634

* https://github.com/pybind/pybind11/blob/dbf848aff7c37ef8798bc9459a86193e28b1032f/include/pybind11/cast.h#L797

Noticed in passing while working on PR pybind#5213.
    Ralf W. Grosse-Kunstleve committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    54fd559 View commit details
    Browse the repository at this point in the history

  3. Add DANGER ZONE comment in detail/init.h, similar to a comment adde… 

    …d on the smart_holder branch (all the way back in 2021).
    Ralf W. Grosse-Kunstleve committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    92d7724 View commit details
    Browse the repository at this point in the history