feat(types): Add special case for empty C++ tuple type annotation #5214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
reviewed
Jun 30, 2024
| public: | ||
| // PEP 484 specifies this syntax for an empty tuple | ||
| static constexpr auto name = const_name("tuple[()]"); | ||
| }; |
There was a problem hiding this comment.
Could you please insert an empty line right after this one?
rwgk
approved these changes
Jun 30, 2024
wenqing
pushed a commit
to wenqing/pybind11
that referenced
this pull request
Jul 6, 2024
…bind#5214) * add special case and unit test * add newline
henryiii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split off from #5212
Due to how tuple_caster implements it's type generation it works for all tuples except the empty tuple which previously generated
tuple[]rather than the correcttuple[()]pybind11/include/pybind11/cast.h
Lines 675 to 677 in 51c2aa1
Suggested changelog entry: