[smart_holder] Remove added return_value_policy members and try_as_void_ptr_capsule feature.
#5160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 10, 2024 18:38
…e_caster_pyobject_ptr.h (backported from google/pybind11clif#30021)" This reverts commit bd69f7a.
…ybind#4609)" This reverts commit 99cf27a.
…atic (pybind#4381)" This reverts commit c1f14f0. Conflicts resolved in: include/pybind11/detail/smart_holder_type_casters.h tests/test_return_value_policy_override.py
)" This reverts commit 8720cf9.
This reverts commit 6d3a0fc.
pybind#3838)" This reverts commit 7064d43. Conflicts resolved in: include/pybind11/eigen.h tests/test_builtin_casters.cpp
rwgk
changed the title
return_value_policy members and try_as_void_ptr_capsule feature.
rwgk
pushed a commit
to rwgk/pybind11clif
that referenced
this pull request
Jun 11, 2024
INTENTIONALLY A NO-OP: See pybind/pybind11#5160
rwgk
pushed a commit
to google/pybind11clif
that referenced
this pull request
Jun 11, 2024
git merge smart_holder (pybind/pybind11#5160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to achieve a cleaner separation of changes:
smart_holder branch: adds
smart_holdertype andtype_caster_odr_guardonly.pybind11clif: everything else needed for the PyCLIF-pybind11 integration (more generally: everything geared towards supporting automatically generating pybind11 bindings code).
All code removed here will continue to exist in the pybind11clif repo.
The
type_caster_odr_guardis not removed here because it can be very helpful for determining wherePYBIND11_SMART_HOLDER_TYPE_CASTERSmacros are missing.Suggested changelog entry: