Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[smart_holder] Fix terrible merge accident: PYBIND11_INTERNALS_SH_DEF missing in PYBIND11_INTERNALS_ID and PYBIND11_MODULE_LOCAL_ID #5159

Merged
merged 2 commits into from
Jun 11, 2024
Merged

[smart_holder] Fix terrible merge accident: PYBIND11_INTERNALS_SH_DEF missing in PYBIND11_INTERNALS_ID and PYBIND11_MODULE_LOCAL_ID #5159

merged 2 commits into from
Jun 11, 2024

Commits on Jun 10, 2024

  1. Fix oversight: Add `-DCMAKE_CXX_FLAGS="-DPYBIND11_USE_SMART_HOLDER_AS… 

    …_DEFAULT"` for new `manylinux` job (Manylinux on 🐍 3.13t • GIL).
    Ralf W. Grosse-Kunstleve committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1d5f549 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Fix terrible merge accident introduced with pybind#5085: `PYBIND11_IN… 

    …TERNALS_SH_DEF` was accidentally removed from `PYBIND11_INTERNALS_ID` and `PYBIND11_MODULE_LOCAL_ID`.
    Ralf W. Grosse-Kunstleve committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    799e2d8 View commit details
    Browse the repository at this point in the history