Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart_holder] git merge master #5157

Merged
merged 10 commits into from
Jun 10, 2024
Merged

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jun 10, 2024

Description

Helper/scratch PR for testing.

Suggested changelog entry:

henryiii and others added 10 commits May 27, 2024 15:03
* Added check on iterator end position

* Always use assert without conditional check

* Addressing code review comments

* style: pre-commit fixes

* Remove assert and throw

* Changed style slightly

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* ci: try Python 3.13t

Signed-off-by: Henry Schreiner <[email protected]>

* fix: support Python 3.13t

Signed-off-by: Henry Schreiner <[email protected]>

* fix: patch PyPy

Signed-off-by: Henry Schreiner <[email protected]>

* tests: one more int cast

Signed-off-by: Henry Schreiner <[email protected]>

* tests: cleanup

Signed-off-by: Henry Schreiner <[email protected]>

* refactor: use named constant in tests for immortal refcounts

Signed-off-by: Henry Schreiner <[email protected]>

* docs: move comment about free threaded Python

Signed-off-by: Henry Schreiner <[email protected]>

---------

Signed-off-by: Henry Schreiner <[email protected]>
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.5 → v0.4.7](astral-sh/ruff-pre-commit@v0.4.5...v0.4.7)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix(cmake): do not use Python::Interpreter when cross-compiling

* chore: apply cmake-format to pybind11NewTools.cmake

* fix(cmake): do not look for Python Interpreter component when cross-compiling

* feat(cmake): guess Python extension suffix

* fix: add pybind11GuessPythonExtSuffix.cmake to packaging test

* Use PYBIND11_CROSSCOMPILING instead of CMAKE_CROSSCOMPILING

* refactor: require PYBIND11_USE_CROSSCOMPILING

Signed-off-by: Henry Schreiner <[email protected]>

---------

Signed-off-by: Henry Schreiner <[email protected]>
Co-authored-by: Henry Schreiner <[email protected]>
* Add a pybing function to clear a list.

* Add required error handling.

* Add `/* py-non-const */` as suggested by @Skylion007

---------

Co-authored-by: Ralf W. Grosse-Kunstleve <[email protected]>
@rwgk
Copy link
Collaborator Author

rwgk commented Jun 10, 2024

Ignoring the 6 failing Python 3.13 builds: The same failures appear under #3939.

@rwgk rwgk merged commit 540c760 into pybind:smart_holder Jun 10, 2024
144 of 150 checks passed
@rwgk rwgk deleted the sh_merge_master branch June 10, 2024 08:04
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jun 10, 2024
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Jun 10, 2024
rwgk pushed a commit to google/pybind11clif that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants