feat: add a pybind function to clear a list. #5153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that this is a system/test configuration/version issue rather than an issue with the CL per se. Could a maintainer have a look? Tthat would be awesome! Thank you very much in advance! Using cmake version 3.29.4 |
|
About to close/reopen this PR to trigger a fresh rerun of the GitHub Actions. |
rwgk
approved these changes
Jun 6, 2024
Skylion007
reviewed
Jun 7, 2024
include/pybind11/pytypes.h
Outdated
| @@ -2183,6 +2183,11 @@ class list : public object { | |||
| throw error_already_set(); | |||
| } | |||
| } | |||
| void clear() { | |||
There was a problem hiding this comment.
Can you add the non-const comment the other pybind11 clear methods have?
There was a problem hiding this comment.
Done. Thanks for catching this!
Skylion007
approved these changes
Jun 7, 2024
henryiii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
py::list::clear().See also: https://stackoverflow.com/questions/23489177/how-to-clear-a-pylistobject
Suggested changelog entry: