Inherit weakref from handle

docs/advanced/misc.rst

@@ -287,7 +287,7 @@ avoids this issue involves weak reference with a cleanup callback:
     );
 
     // Create a weak reference with a cleanup callback and initially leak it
-    (void) py::weakref(m.attr("BaseClass"), cleanup_callback).release();
+    (void) py::weakref(m.attr("BaseClass"), cleanup_callback);
 
 .. note::
 

include/pybind11/pybind11.h

@@ -1694,8 +1694,7 @@ class class_ : public detail::generic_type {
         weakref(m_ptr, cpp_function([ptr](handle wr) {
                     delete ptr;
                     wr.dec_ref();
-                }))
-            .release();
+                }));
         return *this;
     }
 
@@ -2290,7 +2289,6 @@ PYBIND11_NOINLINE void keep_alive_impl(handle nurse, handle patient) {
         weakref wr(nurse, disable_lifesupport);
 
         patient.inc_ref(); /* reference patient and leak the weak reference */
-        (void) wr.release();
     }
 }
 
@@ -2338,8 +2336,7 @@ all_type_info_get_cache(PyTypeObject *type) {
                     }
 
                     wr.dec_ref();
-                }))
-            .release();
+                }));
     }
 
     return res;

include/pybind11/pytypes.h

@@ -1875,6 +1875,7 @@ class weakref : public object {
             pybind11_fail("Could not allocate weak reference!");
         }
     }
+    ~weakref() { release(); }
 
 private:
     static PyObject *raw_weakref(PyObject *o) { return PyWeakref_NewRef(o, nullptr); }