[smart_holder] Smart holder default delete #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures `std::default_delete<T>` is used to look up the deleter for a type instead of `delete` directly.
|
Thanks @iwanders! I'm just waiting for the GHA to finish before merging. It's fine to leave the suggested changelog entry blank, because we don't have smart_holder releases. |
|
👍 good to know, I cleared it from the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rwgk , as requested in #4921 (comment)
Ensures
std::default_delete<T>is used to look up the deleter for a type instead ofdeletedirectly.Description
The smart holder should use
std::default_deletefor looking up a deleter instead of assumingdeleteis the correct thing.Suggested changelog entry: