Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[smart_holder] Unique ptr deleter roundtrip tests and fix #4921

Merged
merged 13 commits into from
Nov 8, 2023
Merged

[smart_holder] Unique ptr deleter roundtrip tests and fix #4921

merged 13 commits into from
Nov 8, 2023

Commits on Nov 4, 2023

  1. Roundtrip through unique pointer with custom deleter. 

    Currently failing.
    @iwanders
    iwanders committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    7cc1e1f View commit details
    Browse the repository at this point in the history

  2. Ensure the custom deleter is copied back to the unique pointer. 

    Feels like there's still a gap around the raw pointer flavour, but this at least
makes the unit test of the previous commit succeed.
    @iwanders
    iwanders committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    5b00921 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Add deleter roundtrip for const atyp. 

    Currently failing, custom deleter is lost.
    @iwanders
    iwanders committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    ad7eaa4 View commit details
    Browse the repository at this point in the history

  2. Fix storing deleter for const unique ptr. 

    Unit test from the previous commit passes.
    @iwanders
    iwanders committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    a49a7ce View commit details
    Browse the repository at this point in the history

  3. Remove SFINEA deleter assignment. 

    At the construction of the smart holder, it is either a del_fun, or a default constructed deleter, so this complexity is unnecessary.
    @iwanders
    iwanders committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    eb05f97 View commit details
    Browse the repository at this point in the history

  4. Clang format.

    @iwanders
    iwanders committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    23d5eac View commit details
    Browse the repository at this point in the history

  5. Fixes for ci. 

    Clang 3.6 requires the extra constructors in the custom_deleter.
    @iwanders
    iwanders committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    8800800 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. fix(smart_holder): Loosen requirement on deleter to be default constr… 

    …uctible.

And some other PR feedback.
    @iwanders
    iwanders committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    f2f87f0 View commit details
    Browse the repository at this point in the history

  2. fix(smart_holder): Custom deleter in unit tests traces constructions.

    @iwanders
    iwanders committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    13105d5 View commit details
    Browse the repository at this point in the history

  3. fix(smart_holder): Use pybind11_fail instead of assert.

    @iwanders
    iwanders committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    4cdd8bb View commit details
    Browse the repository at this point in the history

  4. fix(smart_holder): Add unit tests for the default constructible deleter.

    @iwanders
    iwanders committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    5c062eb View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. fix(smart_holder): Use regex matching for deleter constructors in uni… 

    …t tests.
    @iwanders
    iwanders committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8a75f12 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'smart_holder' into unique_ptr_destructor_roundtrip

    @iwanders
    iwanders authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    1683aee View commit details
    Browse the repository at this point in the history