[smart_holder] Make smart holder type caster of unique_ptr
accept automatic_reference
#4775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling a Python callback function that consumes
std::unique_ptr
in C++, we seeRuntimeError: Invalid return_value_policy for unique_ptr.
This is because when calling Python functions manually from C++ , we usereturn_value_policy::automatic_reference
for function arguments, and the type caster ofstd::unique_ptr
rejects this return value policy.Pybind11 always override
return_value_policy::automatic
andreturn_value_policy::automatic_reference
withreturn_value_policy::move
forstd::unique_ptr
:pybind11/include/pybind11/cast.h
Line 1138 in b644446
return_value_policy::automatic
andreturn_value_policy::automatic_reference
does not make any difference forstd::unique_ptr
. We should make the type caster accept both.