Disable PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF generally for PyPy
#4751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not just PyPy Windows).
EthanSteinberg
approved these changes
Jul 15, 2023
rwgk
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Jul 15, 2023
…not just PyPy Windows). (pybind#4751)
rwgk
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Update README.rst - Add missing comma in the list of acknowlegements (#4750) * Disable `PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF` generally for PyPy (not just PyPy Windows). (#4751) * Update changelog * Provide `PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF` as an option (#4753) * Remove GIL checks * Update common.h * Add flag * style: pre-commit fixes * Update pytypes.h * style: pre-commit fixes * Update common.h * style: pre-commit fixes * Update pytypes.h * style: pre-commit fixes * Update common.h * style: pre-commit fixes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Update changelog: PR #4753 --------- Co-authored-by: bzaar <[email protected]> Co-authored-by: Ethan Steinberg <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
Just like another commenter in #4748 we are seeing similar problems for cpython, not PyPy:
|
|
You are not providing any information how to reproduce what you apparently see as a pybind11 problem: I have to assume you're most likely detecting a bug in client code, exactly what #4246 is meant to do. — Note that the Please provide a reproducer if you believe that there is a problem in pybind11 (and not in client code). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to resolve #4748.
Note that we have this since Apr 2021:
That suggests generally
PyGILState_Check()is working as intended with PyPy, but maybe PyPy's teardown it not GIL clean?Answering this is left for another day.
Suggested changelog entry:
``PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF`` was disabled for PyPy in general (not just PyPy Windows). This is to resolve #4748.