Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update pre-commit hooks #4727

Merged
merged 3 commits into from
Jul 11, 2023
Merged

chore(deps): update pre-commit hooks #4727

merged 3 commits into from
Jul 11, 2023

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jul 4, 2023

@pre-commit-ci
chore(deps): update pre-commit hooks
5c2b85e 
updates:
- [github.com/pre-commit/mirrors-clang-format: v16.0.4 → v16.0.6](pre-commit/mirrors-clang-format@v16.0.4...v16.0.6)
- https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit
- [github.com/astral-sh/ruff-pre-commit: v0.0.270 → v0.0.276](astral-sh/ruff-pre-commit@v0.0.270...v0.0.276)
- [github.com/pre-commit/mirrors-mypy: v1.3.0 → v1.4.1](pre-commit/mirrors-mypy@v1.3.0...v1.4.1)
- [github.com/asottile/blacken-docs: 1.13.0 → 1.14.0](adamchainz/blacken-docs@1.13.0...1.14.0)
- [github.com/codespell-project/codespell: v2.2.4 → v2.2.5](codespell-project/codespell@v2.2.4...v2.2.5)
@pre-commit-ci pre-commit-ci bot requested a review from henryiii as a code owner July 4, 2023 07:58
rwgk
rwgk approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR: Do we still need the PyPy-3.7 build? It's extremely flaky. Would be nice to get rid of that permanent distraction.

@henryiii
Copy link
Collaborator

henryiii commented Jul 4, 2023

pypy3.7 is now longer supported upstream. Neither is pypy3.8, actually, the last release dropped it.

cibuildwheel still supports both, fwiw.

@rwgk
Copy link
Collaborator

rwgk commented Jul 4, 2023

pypy3.7 is now longer supported upstream. Neither is pypy3.8, actually, the last release dropped it.

cibuildwheel still supports both, fwiw.

I really think it's time for us to drop pypy3.7, could you please review: #4728

pypy3.8 is much less flaky, I'm OK to keep that a little longer.

@rwgk rwgk merged commit 47dc0c4 into master Jul 11, 2023
@rwgk rwgk deleted the pre-commit-ci-update-config branch July 11, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii Awaiting requested review from henryiii henryiii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @rwgk