fix: support CMake 3.27, drop 3.4 #4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
reviewed
Jun 27, 2023
henryiii
force-pushed
the
henryiii/fix/cmake27
branch
from
143f0f3
to
c704c1e
Compare
Okay, that's annoying. Will have to protect it, then. |
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/fix/cmake27
branch
from
c704c1e
to
cddb9b8
Compare
rwgk
approved these changes
Jul 9, 2023
|
@henryiii is there a chance that you can finalize & merge this today? I want to update smart_holder & pywrapcc, to catch up with all the small updates here. |
|
@henryiii all tests pass. Looks great to me, could you please merge if the work is complete? |
3 tasks
hoffmang9
added a commit
to Chia-Network/bls-signatures
that referenced
this pull request
Sep 2, 2023
Cmake is deprecating the way pybind finds the python interpreter. See https://cmake.org/cmake/help/latest/policy/CMP0148.html and pybind/pybind11#4719
hoffmang9
added a commit
to Chia-Network/chiapos
that referenced
this pull request
Sep 2, 2023
Cmake is deprecating the way pybind finds the python interpreter. See https://cmake.org/cmake/help/latest/policy/CMP0148.html and pybind/pybind11#4719
hoffmang9
added a commit
to Chia-Network/chiavdf
that referenced
this pull request
Sep 2, 2023
Cmake is deprecating the way pybind finds the python interpreter. See https://cmake.org/cmake/help/latest/policy/CMP0148.html and pybind/pybind11#4719
hoffmang9
added a commit
to Chia-Network/bls-signatures
that referenced
this pull request
Nov 7, 2023
Cmake is deprecating the way pybind finds the python interpreter. See https://cmake.org/cmake/help/latest/policy/CMP0148.html and pybind/pybind11#4719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is roughly what I was thinking to support CMake 3.27.
Suggested changelog entry: