Skip to content

Add option to print # value = comments, disable by default#251

Merged
ax3l merged 4 commits intopybind:mainfrom
dyollb:print_disable_value_comments
Apr 15, 2026
Merged

Add option to print # value = comments, disable by default#251
ax3l merged 4 commits intopybind:mainfrom
dyollb:print_disable_value_comments

Conversation

@dyollb
Copy link
Copy Markdown
Contributor

@dyollb dyollb commented Apr 21, 2025

Fixes #235

@ax3l ax3l added bug Something isn't working labels Apr 15, 2026
@ax3l
Copy link
Copy Markdown
Contributor

ax3l commented Apr 15, 2026

This is a good PR, but I would disable the value comments by default: they have no semantic meaning in tooling and are purely for debugging/visual inspection. Will push a commit.

@ax3l ax3l self-requested a review April 15, 2026 15:48
@ax3l ax3l changed the title add option to disable printing '# value =' comments Add option to print '# value =' comments, disable by default Apr 15, 2026
@ax3l ax3l changed the title Add option to print '# value =' comments, disable by default Add option to print # value = comments, disable by default Apr 15, 2026
@ax3l ax3l self-assigned this Apr 15, 2026
Copy link
Copy Markdown
Contributor

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! 🎉

@ax3l ax3l merged commit 3a2dac9 into pybind:main Apr 15, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optionally disable the # value = ... in Printer

2 participants