Added parameter entry points #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santacodes
requested review from
brosaplanella,
Saransh-cpp,
agriyakhetarpal and
arjxn-py
santacodes
force-pushed
the
parametersets
branch
from
46b7ca3
to
5374988
Compare
|
@arjxn-py @brosaplanella could you please review this PR? |
santacodes
force-pushed
the
parametersets
branch
from
d73b574
to
601df87
Compare
arjxn-py
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Thanks @santacodes, it looks good. I've suggested some improvements. Feel free to let me know in case of something conflicting
Co-authored-by: Arjun Verma <[email protected]>
brosaplanella
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Looks good to me too, a few final comments! Thanks, @santacodes!
Co-authored-by: Agriya Khetarpal <[email protected]>
agriyakhetarpal
approved these changes
Jul 7, 2024
arjxn-py
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Thanks @santacodes, merging this as you must have also started with model entry points so didn't want to hold this.
I hope it didn't raise any bottlenecks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions -
parameter_sets.pyfrom the main PyBaMM repository which acts as an entry point for the parameter sets mapped through the groupcookie_parameter_sets.Chen2020.pyto test and load a parameter set through the entry point to ensure that everything works.Updates -
devsession.pyproject.toml.Accessing parameter sets through entry points here is the same as accessing it through PyBaMM. Instead using
pybamm.parameter_setshere it would implypybamm_cookiecutter.paramter_setsto access them. I think it would make it easier for current users to adapt to the template as the implementations are almost the same. Before release, the template should be modified in compliance with the module name a user would give.