Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal use of deprecated set_parameters method #2 #4639

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Remove internal use of deprecated set_parameters method #2 #4639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/unit/test_simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def test_basic_ops(self):
assert V.has_symbol_of_classes(pybamm.Parameter)
assert not V.has_symbol_of_classes(pybamm.Matrix)

sim._set_parameters()
sim.set_parameters()
assert sim._mesh is None
assert sim._disc is None
V = sim.model_with_set_params.variables["Voltage [V]"]
Expand Down Expand Up @@ -138,8 +138,8 @@ def test_solve_already_partially_processed_model(self):
def test_reuse_commands(self):
sim = pybamm.Simulation(pybamm.lithium_ion.SPM())

sim._set_parameters()
sim._set_parameters()
sim.set_parameters()
sim.set_parameters()

sim.build()
sim.build()
Expand All @@ -149,7 +149,7 @@ def test_reuse_commands(self):

sim.build()
sim.solve([0, 600])
sim._set_parameters()
sim.set_parameters()

def test_set_crate(self):
model = pybamm.lithium_ion.SPM()
Expand Down
Loading