-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary variables calculated only when called #4621
base: develop
Are you sure you want to change the base?
Summary variables calculated only when called #4621
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4621 +/- ##
===========================================
- Coverage 99.21% 99.21% -0.01%
===========================================
Files 302 303 +1
Lines 22858 22928 +70
===========================================
+ Hits 22679 22747 +68
- Misses 179 181 +2 ☔ View full report in Codecov by Sentry. |
self._possible_variables = model.summary_variables # minus esoh variables | ||
self._esoh_variables = [] # Store eSOH variable names | ||
|
||
# Flag if eSOH calculations are needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related: #4619
67542c0
to
b76d866
Compare
Description
Fixes #4058
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: