remove public set_parameters

pybamm-team · Dec 2, 2024 · 66766b8 · 66766b8
1 parent 63d138d
commit 66766b8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/pybamm/simulation.py b/src/pybamm/simulation.py
@@ -344,7 +344,7 @@ def build(self, initial_soc=None, inputs=None):
             self._model_with_set_params = self._model
             self._built_model = self._model
         else:
-            self.set_parameters()
+            self._set_parameters()
             self._mesh = pybamm.Mesh(self._geometry, self._submesh_types, self._var_pts)
             self._disc = pybamm.Discretisation(
                 self._mesh, self._spatial_methods, **self._discretisation_kwargs

diff --git a/tests/unit/test_simulation.py b/tests/unit/test_simulation.py
@@ -31,7 +31,7 @@ def test_basic_ops(self):
         assert V.has_symbol_of_classes(pybamm.Parameter)
         assert not V.has_symbol_of_classes(pybamm.Matrix)
 
-        sim.set_parameters()
+        sim._set_parameters()
         assert sim._mesh is None
         assert sim._disc is None
         V = sim.model_with_set_params.variables["Voltage [V]"]
@@ -138,8 +138,8 @@ def test_solve_already_partially_processed_model(self):
     def test_reuse_commands(self):
         sim = pybamm.Simulation(pybamm.lithium_ion.SPM())
 
-        sim.set_parameters()
-        sim.set_parameters()
+        sim._set_parameters()
+        sim._set_parameters()
 
         sim.build()
         sim.build()
@@ -149,7 +149,7 @@ def test_reuse_commands(self):
 
         sim.build()
         sim.solve([0, 600])
-        sim.set_parameters()
+        sim._set_parameters()
 
     def test_set_crate(self):
         model = pybamm.lithium_ion.SPM()