Introduce lib finalize method #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow explicit calling of C_Finalize
|
LGTM, but we should also test and document this function. Btw. It might also solve an issue I encountered with the unit tests for my own project. |
|
Cool. I will try to put together some test in the coming weeks and also update the docs. |
|
Thanks! Otherwise I see no reason against a merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow explicit calling of C_Finalize.
My use case is a test for my fork of pkcs11-proxy where I added tests which use this project. The way how pkcs11-proxy works is that it creates a daemon which gets the proxied calls. The issue that I have is that in my test I can start the daemon but then I need to also terminate it. However the termination should happen after getting C_Finalize which is difficult to do in pkcs11-proxy because it happens at the end when the garbage is collected. So I would like to do an explicit call to do finalize and then terminate the daemon.