Skip to content

License problem with 16 when installing on Databricks #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

License problem with 16 when installing on Databricks #1011

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91aa8bf
Update pyproject.toml to fix build issue on databricks
dwsmith1983 Oct 17, 2025
95786fa
Merge pull request #1 from dwsmith1983/dwsmith1983-patch-1
dwsmith1983 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ authors = [{ name = "PyWhy contributors" }]
description = "This package contains several methods for calculating Conditional Average Treatment Effects"
readme = "README.md"
keywords = ["treatment-effect"]
license = "MIT"
Copy link
Collaborator

@kbattocchi kbattocchi Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP 621 has been superseded by PEP 639 and is now deprecated - see https://packaging.python.org/en/latest/specifications/pyproject-toml/#license and https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license-and-license-files, so we definitely do not want to make this change.

This is not a problem when using a recent version of setuptools. I think just updating setuptools (via pip install -U setuptools if you're in an environment managed by pip) should fix any issues; perhaps we could change line 69 to "setuptools>77.03" to force a more recent version but reverting to the deprecated license scheme doesn't make sense.

Copy link
Author

@dwsmith1983 dwsmith1983 Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbattocchi please test your suggestion on Databricks. We cannot override pre-installed packages even if we upgrade it. This is on DBR 17

Installing collected packages: setuptools
  Attempting uninstall: setuptools
    Found existing installation: setuptools 74.0.0
    Not uninstalling setuptools at /usr/local/lib/python3.12/dist-packages, outside environment /local_disk0/.ephemeral_nfs/envs/pythonEnv-07bbc370-afd6-4f28-8e32-234ba964c593
    Can't uninstall 'setuptools'. No files were found to uninstall.
Successfully installed setuptools-80.9.0

Now install econml:

  Downloading econml-0.16.0.tar.gz (1.7 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/1.7 MB ? eta -:--:--
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.7/1.7 MB 48.5 MB/s eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [95 lines of output]
      configuration error: `project.license` must be valid exactly by one definition (2 matches found):
      
          - keys:
              'file': {type: string}
            required: ['file']
          - keys:
              'text': {type: string}
            required: ['text']
      
      DESCRIPTION:
          `Project license <[https://peps.python.org/pep-0621/#license>`_](https://peps.python.org/pep-0621/#license%3E%60_).
      
      GIVEN VALUE:
          "MIT"

license = { text = "MIT" }
dynamic = ["version"]

classifiers = [
Expand Down
Loading