Skip to content

STY: Remove variable check_crlf_space #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Jan 30, 2025

No description provided.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (3c72462) to head (514982d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3096      +/-   ##
==========================================
- Coverage   96.60%   96.60%   -0.01%     
==========================================
  Files          53       53              
  Lines        8979     8974       -5     
  Branches     1659     1659              
==========================================
- Hits         8674     8669       -5     
  Misses        183      183              
  Partials      122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefan6419846
Copy link
Collaborator

Doesn't this decrease readability/overview?

@j-t-1
Copy link
Contributor Author

j-t-1 commented Jan 31, 2025

Whether to check_crlf_space depends on if operator in ( b"Td", b"Tm", b"T*", b"Tj"). So the variable is recording something we already know and thus decreases readability.

@stefan6419846 stefan6419846 added the on-hold PR requests that need clarification before they can be merged.A comment must give details label Feb 2, 2025
@stefan6419846 stefan6419846 merged commit a37063d into py-pdf:main Apr 17, 2025
16 checks passed
@j-t-1 j-t-1 deleted the simplify branch April 17, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold PR requests that need clarification before they can be merged.A comment must give details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants