Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed-up builds #328

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Speed-up builds #328

merged 2 commits into from
Dec 24, 2023

Conversation

ewjoachim
Copy link
Member

@ewjoachim ewjoachim commented Dec 24, 2023

Closes #268

This PR adds a test when building Dockerfile at the start of the action that only runs pip install if pyproject.toml has changed since the image was built.

Copy link

End-to-end public repo

Other commands:

  • Have an admin approve a review with /e2e to trigger end-to-end tests on external contributions
  • Comment with /invite to invite the author & admins to the end-to-end private repo

Copy link

Coverage report

The coverage rate went from 100% to 100% ➡️
The branch rate is 100%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@ewjoachim
Copy link
Member Author

To test this, I'll need to push v5 from my laptop. So I'll need to build v5 locally. Now that my laptop is an ARM, I'll need to learn how to cross-build docker images for x64. Seems feasible but... For another day.

@ewjoachim ewjoachim merged commit d69bfc0 into main Dec 24, 2023
2 checks passed
@ewjoachim ewjoachim deleted the speed-up-build branch December 24, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions for running built docker container.
1 participant