Skip to content

Commit

Permalink
Update release.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
ewjoachim authored Sep 1, 2023
1 parent e79b1ab commit 940a109
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
set -eux
git fetch --tags origin
current="$(git describe --tags --abbrev=0 --match 'v*.*')"
Expand All @@ -63,7 +64,7 @@ jobs:
git push -f origin ${major}
# Major releases will be released manually.
patch=$((patch + 1))
minor=$((minor + 1))
new_tag="${major}.${minor}"
gh release create ${new_tag} --generate-notes

1 comment on commit 940a109

@kieferro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure I understand the version system anymore. We now tag and release every commit for which the CI runs. What exactly is the advantage of this over commit SHAs? (except that commits that are pushed at the same time are skipped). I'm not sure if our current release frequency (5 releases in 2 days) makes sense.

Please sign in to comment.