Skip to content

Commit

Permalink
Merge pull request #326 from py-cov-action/artifact-v4
Browse files Browse the repository at this point in the history
  • Loading branch information
ewjoachim authored Dec 23, 2023
2 parents 7585e40 + ac1a239 commit 127c420
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
ANNOTATE_MISSING_LINES: true

- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
name: python-coverage-comment-action
Expand Down
15 changes: 8 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}

- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
# If you use a different name, update COMMENT_ARTIFACT_NAME accordingly
Expand Down Expand Up @@ -252,9 +252,9 @@ jobs:
# directly or through PYTEST_ADD_OPTS.

- name: Store coverage file
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage
name: coverage-${{ matrix.python_version }}
path: .coverage.${{ matrix.python_version }}

coverage:
Expand All @@ -267,10 +267,11 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
id: download
with:
name: "coverage"
pattern: coverage-*
merge-multiple: true

- name: Coverage comment
id: coverage_comment
Expand All @@ -280,7 +281,7 @@ jobs:
MERGE_COVERAGE_FILES: true

- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
name: python-coverage-comment-action
Expand Down Expand Up @@ -454,7 +455,7 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}
- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: steps.coverage_comment_1.outputs.COMMENT_FILE_WRITTEN == 'true' || steps.coverage_comment_2.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
name: python-coverage-comment-action
Expand Down
2 changes: 1 addition & 1 deletion tests/end_to_end/repo/.github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
SUBPROJECT_ID: __ACTION_SUBPROJECT_ID__

- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
name: python-coverage-comment-action
Expand Down

0 comments on commit 127c420

Please sign in to comment.