-
Notifications
You must be signed in to change notification settings - Fork 145
Modified scoreboard to display school logo for users with school emails like ASU users (added Big 12 logos) #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…elected based on email in dojo_plugin
If this implementation ends up working, I can expand the school list to beyond the Big 12, and we will also probably need to move the email_symbol_asset() code to its own file since it'll turn into a mile long list of match case statements. |
Why not just do something like this? def email_symbol_asset(email):
email_domain = email.split("@")[1]
if email_domain.endswith(".edu"):
school = email_domain[:-len(".edu")]
schools = get_schools() # get list of schools somehow
if school in schools:
group = f"schools/{school}.png"
else:
group = "student.png"
else:
group = "hacker.png"
return url_for("views.themes", path=f"img/dojo/{group}") This would require renaming every image to the school’s domain, including fork.png to schools/asu.png |
I added the change to make the images have the school email domains as their name to make it easier to match them. As for the image size standardization, I don't do much front end but I threw in an attempt in the CSS. |
Hey, thanks for contributing! I think the idea of some group rivalry/pride/etc sounds fun. A few thoughts:
I do think there is something compelling about this group rivalry/pride/etc sort of idea, I'm just not totally sure what the right way is to express it visually or otherwise. I'd be super interested if you have more thoughts. Thanks! |
You bring up some good points. These policy decisions are ultimately up to ASU and the pwn.college maintainers, but here are my thoughts:
|
Something else to consider: as always, the safest bet when it comes to copyright/trademark concerns is to just get permission from the owner. This approach would obviously be the most amount of work compared to any of the others, but could provide some additional peace of mind for anyone who might be worried about pwn.college's ability to use the logos. I imagine the best way to accomplish that would be to draft some sort of request letter outlining details of who is asking for permission and what the specific intended use would be. Then, slowly roll out each logo on the site as each school responds with approval (if they do provide approval). Besides the time this would likely take, another downside of this approach could be that by making a formal request, it may force the schools to formally respond. By this I mean they may be forced to reject the request or very narrowly provide approval based on their legal counsel's guidelines, even if said schools didn't otherwise have any issue with the specific logo use prior to be asked to formally decide. This scenario, of course, is only potentially relevant if the pwn.college maintainers decide they believe the use case for the logos does in fact have a good argument for fair use. Lastly, whether or not a request letter is sent, it would likely be fairly safe (again, in my non-expert legal opinion) to use the logos to the best of our understanding of fair use law, including adding disclaimers, and simply being prepared to take any or all of the logos down fairly quickly should a school or other entity express disapproval of the use. Since pwn.college is free and educational in nature, any legal action would essentially be limited to requesting that the logos be removed, as it would be hard to argue that a free learning platform had some sort of monetary benefit from the use of 3rd party material. |
We had a discussion about this feature. The takeaway was that a few changes are needed in order to merge it in.
This means it needs a bit of UI work to somehow allow the user to select the affiliation avatar image. Similarly, we'd need to create an "affiliation image" database table as well as add a reference column to the users table to indicate the user's selected affiliation avatar preference. |
School logos use the same logic as the ASU logo code.
Didn't get the chance to setup a full local pwn.college instance yet so this code will need to be run in test environment to make sure it renders properly.