Conversation
- Update optional dependency from 'nrel-pysam' to 'nlr-pysam' - Uncomment nlr-pysam in Python 3.14 CI requirements - PySAM 8.0.0+ is distributed as nlr-pysam for Python 3.8-3.14 Note: test_fit_cec_sam shows minor numerical differences between nlr-pysam 8.0.0+ and nrel-pysam, particularly in the 'Adjust' parameter. This may indicate algorithmic changes in the newer nlr-pysam distribution that needs further investigation. Fixes pvlib#2871
Hey @mokazemi! 🎉Thanks for opening your first pull request! We appreciate your If AI is used for any portion of this PR, you must vet the content |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
nrel-pysamtonlr-pysamnlr-pysamfor Python 3.8-3.14Testing
The existing test
test_fit_cec_samshows minor numerical differences when usingnlr-pysam8.0.0+:This may indicate algorithmic improvements or changes in nlr-pysam and should be reviewed by maintainers familiar with the PySAM library.
Closes #2871
nlr-pysampackage name #2871docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.