Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation issue on elder compilers: replace constexpr EPSILON by template function. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mr-Question
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   99.32%   99.32%   +<.01%     
==========================================
  Files           9        9              
  Lines         742      744       +2     
==========================================
+ Hits          737      739       +2     
  Misses          5        5
Impacted Files Coverage Δ
include/MyGAL/util.h 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe5afc...e6af28c. Read the comment docs.

@pvigier
Copy link
Owner

pvigier commented Jun 4, 2019

Hi,

Which C++ norm are you targeting ? constexpr variables should be OK in C++11, I guess.

I should have mentioned that somewhere in the README but MyGAL currently targets C++14 and beyond.

Best,
Pierre

@Mr-Question
Copy link
Author

Mr-Question commented Jun 4, 2019

I am ashamed to admit, but there still be a chance to use Visual Studio 2008 in some cases.
As for current issue, the target is C++03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants