Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time flag in kapp #44

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

Dhananjhay
Copy link
Contributor

The kapp CLI currently lacks a --time flag and defaults to allocating 1 hour for building an image. While this duration works well for small to medium-sized images, it often falls short for larger images likedocker://micalab/micapipe:v0.2.3, where more time is needed to complete the pull and build processes. Adding a --time flag would allow users greater flexibility when working with larger images.

The --time flag would accept an integer input representing hours (e.g., [x:int]:00). Given that building an image rarely requires more than 24 hours, limiting the time allocation to hours should be sufficient for all use cases, including those with extensive build requirements.

@pvandyken
Copy link
Owner

I'm fine with this, thanks!

@pvandyken pvandyken merged commit a502216 into pvandyken:master Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants