Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to mautrix-go #38

Merged
merged 11 commits into from
Mar 13, 2022
Merged

Switch to mautrix-go #38

merged 11 commits into from
Mar 13, 2022

Conversation

CubicrootXYZ
Copy link
Collaborator

In order to get more features (e.g. encryption #24) switch from the default matrix go library to mautrix-go.

@CubicrootXYZ CubicrootXYZ added the enhancement New feature or request label Feb 9, 2022
@CubicrootXYZ CubicrootXYZ linked an issue Feb 9, 2022 that may be closed by this pull request
Does pushbits server support end-to-end encryption? Messages are sent unencrypted to Matrix. #24
Open
@CubicrootXYZ CubicrootXYZ marked this pull request as draft February 9, 2022 19:20
@CubicrootXYZ
Copy link
Collaborator Author

Code wise the work is done, needs testing now.

eikendev
eikendev reviewed Feb 10, 2022
View reviewed changes
Copy link
Member

@eikendev eikendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks a lot simpler that I had imagined; good job. What kind of testing do you mean, function tests or manual testing?

internal/dispatcher/application.go Outdated Show resolved Hide resolved
internal/dispatcher/dispatcher.go Outdated Show resolved Hide resolved
internal/dispatcher/notification.go Outdated Show resolved Hide resolved
internal/dispatcher/notification.go Outdated Show resolved Hide resolved
@CubicrootXYZ CubicrootXYZ marked this pull request as ready for review February 11, 2022 21:12
@CubicrootXYZ
Copy link
Collaborator Author

Wow, this looks a lot simpler that I had imagined; good job. What kind of testing do you mean, function tests or manual testing?

Manual testing if everything still works, did not do that yesterday but did it now.

@eikendev eikendev mentioned this pull request Feb 11, 2022
Merged
@CubicrootXYZ
Copy link
Collaborator Author

matrix.org seems to have some trouble currently, will try testing it later again.

@CubicrootXYZ
Copy link
Collaborator Author

Digging deeper I think the issue is that the session from the bot is not verified and therefore the clients from other users will ignore any event sent to them.

@CubicrootXYZ
Copy link
Collaborator Author

Everything working fine - somehow my bot got on the ignored list, my bad. Tested it and it is working just fine.

@eikendev
Copy link
Member

eikendev commented Mar 6, 2022

Thanks for rebasing, I'll take a look this week!

eikendev
eikendev requested changes Mar 13, 2022
View reviewed changes
Copy link
Member

@eikendev eikendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this, just want to clarify some minor things.

go.mod Outdated Show resolved Hide resolved
internal/dispatcher/dispatcher.go Outdated Show resolved Hide resolved
internal/dispatcher/notification.go Show resolved Hide resolved
@eikendev eikendev removed a link to an issue Mar 13, 2022
Does pushbits server support end-to-end encryption? Messages are sent unencrypted to Matrix. #24
Open
@eikendev
Copy link
Member

Removed the link to #24 as it seems more work would be required for E2E. Is this ready to be merged from your PoV?

@CubicrootXYZ
Copy link
Collaborator Author

Removed the link to #24 as it seems more work would be required for E2E. Is this ready to be merged from your PoV?

yes, it is.

@eikendev eikendev merged commit 54bc389 into main Mar 13, 2022
@eikendev eikendev deleted the #24-switch-to-mautrix branch March 13, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikendev eikendev eikendev requested changes

Assignees
No one assigned
Labels
enhancement New feature or request security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CubicrootXYZ @eikendev